Skip to content

fix(strategy): add warning for non-intended exchange_id in virtual trading mode #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DigHuang merged 3 commits into from
Dec 8, 2025
+11 −1
Merged

fix(strategy): add warning for non-intended exchange_id in virtual trading mode #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b2ad7a
fix(strategy): add warning for non-intended exchange_id in virtual tr…
vcfgv Dec 8, 2025
d23cbae
fix(strategy): set exchange_id to None for virtual trading requests o…
vcfgv Dec 8, 2025
653d2e5
fix(config): remove redundant '(free)' label from Grok 4.1 Fast model…
vcfgv Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/configs/providers/openrouter.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ models:
- id: "google/gemini-3-pro-preview"
name: "Gemini 3 Pro Preview"
- id: "x-ai/grok-4.1-fast"
name: "Grok 4.1 Fast(free)"
name: "Grok 4.1 Fast"

# ============================================
# Embedding Models Configuration
Expand Down
10 changes: 10 additions & 0 deletions python/valuecell/server/api/routers/strategy_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
StrategyStatus,
StrategyStatusContent,
StrategyType,
TradingMode,
UserRequest,
)
from valuecell.config.loader import get_config_loader
Expand Down Expand Up @@ -73,6 +74,15 @@ def _safe_config_dump(req: UserRequest) -> dict:
request.trading_config.initial_free_cash = (
request.trading_config.initial_capital
)
if (
request.exchange_config.trading_mode == TradingMode.VIRTUAL
and request.exchange_config.exchange_id not in {None, ""}
):
logger.warning(
"Virtual trading requested on non-default exchange_id '{}'. Ensure this is intended.",
request.exchange_config.exchange_id,
)
request.exchange_config.exchange_id = None
# Ensure we only serialize the core UserRequest fields, excluding conversation_id
user_request = UserRequest(
llm_model_config=request.llm_model_config,
Expand Down