Fixed Assests

VanillePlugin · May 18, 2020 · a523fe7 · a523fe7
1 parent beca935
commit a523fe7
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 7 deletions.
diff --git a/composer.json b/composer.json
@@ -1,6 +1,6 @@
 {
   "name": "jakiboy/vanilleplugin",
-  "version" : "0.0.8",
+  "version" : "0.0.9",
   "type": "library",
   "description": "Framwork for VanillePlugin",
   "keywords": ["VanillePlugin","WordPress","WordPress-Plugin","WordPress-Plugin-Framework","jakiboy"],

diff --git a/src/lib/PluginOptions.php b/src/lib/PluginOptions.php
@@ -176,7 +176,7 @@ protected function addPluginSubMenuPage($callable, $slug, $title = '', $parent =
 	 * @param {inherit}
 	 * @return {inherit}
 	 */
-	protected function addPluginJS($path, $deps = [], $version = false, $footer = false)
+	protected function addPluginJS($path, $deps = [], $version = false, $footer = true)
 	{
 		$id = str_replace('.js', '', basename($path));
 		$id = str_replace('.min', '', $id);
@@ -192,7 +192,7 @@ protected function addPluginJS($path, $deps = [], $version = false, $footer = fa
 	 * @param {inherit}
 	 * @return {inherit}
 	 */
-	protected function addPluginMainJS($path, $deps = [], $version = false, $footer = false)
+	protected function addPluginMainJS($path, $deps = [], $version = false, $footer = true)
 	{
 		$path = "{$this->getAsset()}{$path}";
 		$this->addJS("{$this->getNameSpace()}-main",$path,$deps,$version,$footer);
@@ -206,7 +206,7 @@ protected function addPluginMainJS($path, $deps = [], $version = false, $footer
 	 * @param {inherit}
 	 * @return {inherit}
 	 */
-	protected function addPluginGlobalJS($path, $deps = [], $version = false, $footer = false)
+	protected function addPluginGlobalJS($path, $deps = [], $version = false, $footer = true)
 	{
 		$path = "{$this->getAsset()}{$path}";
 		$this->addJS("{$this->getNameSpace()}-global",$path,$deps,$version,$footer);
@@ -235,7 +235,22 @@ protected function localizePluginJS($content = [], $id = 'main')
 	 * @param string $name
 	 * @return {inherit}
 	 */
-	protected function addPluginCSS($path, $deps = [], $version = '', $media = 'all')
+	protected function localizeGlobalJS($content = [], $id = 'global')
+	{
+		$prefix = str_replace('-', '', $this->getNameSpace());
+		$object = "{$prefix}Global";
+		$this->localizeJS("{$this->getNameSpace()}-{$id}",$object,$content);
+	}
+
+	/**
+	 * Update the value of an option that was already added
+	 *
+	 * @since 4.0.0
+	 * @access protected
+	 * @param string $name
+	 * @return {inherit}
+	 */
+	protected function addPluginCSS($path, $deps = [], $version = false, $media = 'all')
 	{
 		$id = str_replace('.css', '', basename($path));
 		$id = str_replace('.min', '', $id);
@@ -251,7 +266,7 @@ protected function addPluginCSS($path, $deps = [], $version = '', $media = 'all'
 	 * @param string $name
 	 * @return {inherit}
 	 */
-	protected function addPluginMainCSS($path, $deps = [], $version = '', $media = 'all')
+	protected function addPluginMainCSS($path, $deps = [], $version = false, $media = 'all')
 	{
 		$path = "{$this->getAsset()}{$path}";
 		$this->addCSS("{$this->getNameSpace()}-main",$path,$deps,$version,$media);

diff --git a/src/lib/WordPress.php b/src/lib/WordPress.php
@@ -348,7 +348,7 @@ protected function addCSS($id, $path, $deps = [], $version = false, $media = 'al
 	 * @param string $footer
 	 * @return void
 	 */
-	protected function addJS($id, $path, $deps = [], $version = false, $footer = true)
+	protected function addJS($id, $path, $deps = [], $version = false, $footer = false)
 	{
 		if ( strpos($path, 'http') == false ){
 		    $path = $this->getPluginUrl($path);