Make file search script use project root dynamically #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Read docroot from .ddev/config.yaml - Support both docroot and web directories - Prevent unbound variable errors in scripts
Update dev-cspell
Update dev-eslint
Update dev-stylelint
Collaborator
abdullahajam
left a comment
abdullahajam
left a comment
There was a problem hiding this comment.
I truly appreciate your contribution @Yazanmy. But for now, we will keep the files I/O out of the equation, and keep the awk away from spawning extra processes on the server, as we have a very limited resources on it.
We will stick with having docroot or web directories by checking them manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
How This PR Solves The Issue
Manual Testing Instructions
Automated Testing Overview
Release/Deployment Notes