Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added a contributors page to the application with dynamic fetching #35

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

ARYPROGRAMMER
Copy link
Contributor

Description

Created a dedicated Contributors page to showcase all individuals who have contributed to the SocioSell project. The page dynamically displays contributor details to recognize their efforts and foster community engagement.

Related Issue

Fixes #27 and closes it

Motivation and Context

This is an important change to showcase the contributors' efforts.

How Has This Been Tested?

Tested on local machine.
Ran on localhost:5500.
Used personal github access token with all permissions enabled.

Screenshots (if appropriate):

final-demo.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist:

  • My code follows the code style of this project
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

Signed-off-by: Arya Pratap Singh <notaryasingh@gmail.com>
Signed-off-by: Arya Pratap Singh <notaryasingh@gmail.com>
@ARYPROGRAMMER
Copy link
Contributor Author

ARYPROGRAMMER commented Jan 9, 2025

@Varsha-1605 please review and let me know further, thanks.

@Varsha-1605
Copy link
Owner

@ARYPROGRAMMER, everything looks perfect, but is it possible for the profile image to be displayed properly?

@ARYPROGRAMMER
Copy link
Contributor Author

@ARYPROGRAMMER, everything looks perfect, but is it possible for the profile image to be displayed properly?

yes absolutely, allow me few hours i'll see what i can do

Signed-off-by: Arya Pratap Singh <notaryasingh@gmail.com>
@ARYPROGRAMMER
Copy link
Contributor Author

@Varsha-1605 I think these should be much better, not an expert frontend designer but this looks much better i suppose.

image1
image2

@Varsha-1605
Copy link
Owner

@ARYPROGRAMMER Good Work!!

@Varsha-1605 Varsha-1605 merged commit 32e49dd into Varsha-1605:main Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Custom Issue]: Develop a Contributors Page
2 participants