Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

training sword #570

Merged
merged 10 commits into from
Nov 20, 2024
Merged

Conversation

6SpadesLuke
Copy link
Contributor

A training sword for practice dueling.

Description

A wooden sword used for practicing dueling. It can be made at a weapons workbench by using 3 planks.

Deals 2 blunt damage (50+ strikes to crit on a humanoid target)
And deals 5 Stamina damage (20+ strikes to down on a humanoid target)


Training sword

Training Sword

a training sword for practice dueling
slightly more cost
Copy link
Contributor

github-actions bot commented Oct 10, 2024

RSI Diff Bot; head commit 5bf9710 merging into 8a14d6f
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_Nuclear14/Objects/Weapons/Melee/training_sword.rsi

State Old New Status
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after 5bf9710

@Peptide90
Copy link
Collaborator

Looks good however the ID isn't very good imo.

Looking at that file though none of them are good. So I'll likely merge this then change all the IDs to include weapon in the ID.

@6SpadesLuke
Copy link
Contributor Author

I dont really know how to do standalone weapons so I need help on this

@Peptide90
Copy link
Collaborator

The only issue now is the sprites. The inhands sprites are both 32x32 when the total sheet should be 64x64 made up of the 4 directions at 32x32 each.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

I found the issue, it was an exporting error when I was spriting
Peptide90 pushed a commit that referenced this pull request Nov 11, 2024
# Description
Captain's Carapace inherited HidesHarpyWings because wizden made it
parent off Large outerwear for reasons. I've moved HidesHarpyWings to
only LargeOuterwear that actually have harpy sprites so that this won't
happen again.


![image](https://github.com/user-attachments/assets/84ee06e3-eeeb-4193-8cb0-492bd1d3d82e)


![image](https://github.com/user-attachments/assets/ac9493b3-75e7-4696-b531-18b00d1332a5)
@Peptide90 Peptide90 merged commit 255c83d into Vault-Overseers:master Nov 20, 2024
9 checks passed
@6SpadesLuke
Copy link
Contributor Author

you know I should've made a way to craft this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants