Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambient music #99

Merged
merged 10 commits into from
Dec 22, 2023
Merged

Ambient music #99

merged 10 commits into from
Dec 22, 2023

Conversation

Peptide90
Copy link
Collaborator

@Peptide90 Peptide90 commented Aug 17, 2023

About the PR

This PR is based on the upstream merge PR, Merge latest master before proceeding.

Adds ambient music tracks from the Fallout games to the world.

TODO:

  • Create an Audio/N14 folder and move our lobby music into there under Audio/N14/Lobby
  • Add the F2 audio tracks from https://archive.org/details/AURAL01 to Audio/N14/Ambience/F2
  • Add the F2 audio tracks to 'soundCollection's, may be mostly a wasteland collection.
  • Add F3 audio tracks from https://archive.org/details/fallout_3_soundtrack to Audio/N14/Ambience/F3 - Some of these should be used for 'nearAirlock' so they work for vaults and bunkers or - '!type:NearbyTilesPercentRule'
  • Check through FNV audio tracks here, lots of ambience, add where necessary as new collections. https://archive.org/details/falloutnewvegas_ost
  • Fallout 4 to round it out. https://archive.org/details/fallout_4_soundtrack_score
  • Add an appropriate attributions file per subfolder with the license information.
  • Make sure we don't go overboard with 200 ambient soundtracks. Keep it modest but have a good variety of tracks proportional to the amount of time you will hear them.

Bonus:

@Peptide90 Peptide90 self-assigned this Aug 17, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added No C# For easier issues relating to YAML and removed Changes: UI labels Aug 30, 2023
@Peptide90 Peptide90 marked this pull request as ready for review August 30, 2023 21:18
@Peptide90
Copy link
Collaborator Author

Tested in game, presume .mp3 isn't supported so may need to convert to .ogg.

PR on hold for now.

@Peptide90
Copy link
Collaborator Author

Tested in game and works. It's a little loud for ambience but we can cross that bridge later. Also need to assign more rules to more tile types.

@Peptide90 Peptide90 merged commit 505173b into master Dec 22, 2023
5 of 6 checks passed
@Peptide90 Peptide90 deleted the ambient-music branch December 22, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# For easier issues relating to YAML Status: Needs Review
Projects
Development

Successfully merging this pull request may close these issues.

1 participant