CFString Data Renderer #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpalmisc
reviewed
Jan 10, 2023
Comment on lines
+183
to
+190
| auto string = reader.ReadString(size); | ||
|
|
||
| DisassemblyTextLine line; | ||
| line.addr = address; | ||
| line.tokens = prefix; | ||
| line.tokens.emplace_back(StringToken, "@\"" + string + "\"", dataPointer); | ||
| line.tokens.emplace_back(TextToken, ", "); | ||
| line.tokens.emplace_back(IntegerToken, std::to_string(size), dataPointer); |
There was a problem hiding this comment.
We already have StringDataRenderer in the core which should give you line wrapping, etc. for free. It might make more sense to call the string data renderer on the underlying (null-terminated) string, then insert additional tokens as necessary.
(Yes, I know this code is largely pirated from one of my old branches where I didn't do this...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Vector35/binaryninja-api#5586
Ports
cfstring-rendererbranch to latest w/ some fixes.