Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert task classes to more generic so they can be re-used #504

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

amrit110
Copy link
Member

@amrit110 amrit110 commented Nov 14, 2023

PR Type ([Feature | Fix | Documentation | Test])

Fix/Refactor

Short Description

  • Remove specific tasks, and make them more generic.
  • Remove mypy ignore for tasks package and fix typing issues

Tests Added

...

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #504 (09d4de6) into main (d59d1cc) will decrease coverage by 0.13%.
The diff coverage is 29.71%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
- Coverage   62.30%   62.17%   -0.13%     
==========================================
  Files          87       85       -2     
  Lines        8454     8431      -23     
==========================================
- Hits         5267     5242      -25     
- Misses       3187     3189       +2     
Files Coverage Δ
cyclops/models/wrappers/utils.py 61.68% <100.00%> (ø)
cyclops/tasks/base.py 84.50% <100.00%> (ø)
cyclops/tasks/utils.py 54.54% <57.14%> (ø)
cyclops/tasks/classification.py 31.46% <23.57%> (-50.35%) ⬇️

Impacted file tree graph

@amrit110 amrit110 merged commit 3bba828 into main Nov 14, 2023
7 of 9 checks passed
@amrit110 amrit110 deleted the make_tasks_generic branch November 14, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant