Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up process package fns, enable mypy #505

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Conversation

amrit110
Copy link
Member

PR Type ([Feature | Fix | Documentation | Test])

Refactor

Short Description

  • Enable mypy for process package and fix typing issues
  • Remove column names and functions that acted on specific columns to improve generalizability

Tests Added

...

@amrit110 amrit110 self-assigned this Nov 15, 2023
@amrit110 amrit110 added the refactor Refactor existing code, with same or similar functionality label Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #505 (f75f508) into main (aee3f78) will decrease coverage by 0.35%.
The diff coverage is 90.08%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #505      +/-   ##
==========================================
- Coverage   63.70%   63.36%   -0.35%     
==========================================
  Files          96       95       -1     
  Lines        9409     9315      -94     
==========================================
- Hits         5994     5902      -92     
+ Misses       3415     3413       -2     
Files Coverage Δ
cyclops/process/clean.py 95.55% <100.00%> (+1.65%) ⬆️
cyclops/process/constants.py 100.00% <100.00%> (ø)
cyclops/process/diagnoses.py 79.41% <100.00%> (-0.59%) ⬇️
cyclops/process/feature/handle_types.py 79.91% <100.00%> (ø)
cyclops/process/feature/normalize.py 86.98% <100.00%> (ø)
cyclops/process/feature/split.py 98.87% <100.00%> (ø)
cyclops/process/feature/vectorized.py 67.43% <100.00%> (ø)
cyclops/process/impute.py 80.39% <100.00%> (ø)
cyclops/process/string_ops.py 91.80% <100.00%> (ø)
cyclops/process/util.py 100.00% <100.00%> (+1.44%) ⬆️
... and 3 more

Impacted file tree graph

@amrit110 amrit110 merged commit 6cd07b3 into main Nov 17, 2023
8 of 9 checks passed
@amrit110 amrit110 deleted the refactor_process_package branch November 17, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor existing code, with same or similar functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant