Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MetricDict #533

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Add MetricDict #533

merged 2 commits into from
Dec 13, 2023

Conversation

fcogidi
Copy link
Collaborator

@fcogidi fcogidi commented Dec 13, 2023

PR Type

Feature.

Short Description

Add MetricDict for grouping metrics and performing computations on them as one object.

Tests Added

tests/cyclops/evaluate/metrics/experimental/test_metric_dict.py

@fcogidi fcogidi added enhancement New feature or request refactor Refactor existing code, with same or similar functionality labels Dec 13, 2023
@fcogidi fcogidi requested a review from amrit110 December 13, 2023 22:05
@fcogidi fcogidi self-assigned this Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #533 (8574c31) into main (fdee1d8) will increase coverage by 0.46%.
The diff coverage is 92.73%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
+ Coverage   67.19%   67.65%   +0.46%     
==========================================
  Files         103      104       +1     
  Lines        9860    10039     +179     
==========================================
+ Hits         6625     6792     +167     
- Misses       3235     3247      +12     
Files Coverage Δ
cyclops/evaluate/metrics/experimental/metric.py 82.81% <100.00%> (+0.52%) ⬆️
...clops/evaluate/metrics/experimental/metric_dict.py 92.61% <92.61%> (ø)

Impacted file tree graph

@fcogidi fcogidi merged commit cbe9eeb into main Dec 13, 2023
7 checks passed
@fcogidi fcogidi deleted the add_metric_dict branch December 13, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Refactor existing code, with same or similar functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants