Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AUROC #546

Merged
merged 4 commits into from
Jan 12, 2024
Merged

Add AUROC #546

merged 4 commits into from
Jan 12, 2024

Conversation

fcogidi
Copy link
Collaborator

@fcogidi fcogidi commented Jan 12, 2024

PR Type

Feature.

Short Description

Add AUROC metric to the experimental metrics module.

Tests Added

tests/cyclops/evaluate/metrics/test_auroc.py

@fcogidi fcogidi added enhancement New feature or request refactor Refactor existing code, with same or similar functionality labels Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (6a91acf) 69.67% compared to head (4fd59d1) 70.02%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
+ Coverage   69.67%   70.02%   +0.35%     
==========================================
  Files         112      114       +2     
  Lines       10706    10916     +210     
==========================================
+ Hits         7459     7644     +185     
- Misses       3247     3272      +25     
Files Coverage Δ
cyclops/evaluate/metrics/experimental/auroc.py 100.00% <100.00%> (ø)
.../experimental/functional/precision_recall_curve.py 86.23% <ø> (ø)
...ps/evaluate/metrics/experimental/functional/roc.py 90.38% <ø> (ø)
.../evaluate/metrics/experimental/functional/auroc.py 94.31% <94.31%> (ø)
cyclops/evaluate/metrics/experimental/utils/ops.py 86.24% <69.14%> (-2.95%) ⬇️

Impacted file tree graph

@fcogidi fcogidi merged commit df4739d into main Jan 12, 2024
9 checks passed
@fcogidi fcogidi deleted the add_auroc branch January 12, 2024 22:45
rjavadi pushed a commit that referenced this pull request Jan 30, 2024
* Add AUROC metric to experimental module

* Refactor binary and multiclass ROC functions

* Refactor tests to use a common thresholds list

* Fix mypy error
amrit110 added a commit that referenced this pull request Feb 11, 2024
* Changed documentation theme to sphinx-book-theme

* Added details about Pandoc requirment

* Added initial document for accuracy.py

* Fix pre-commit hook errors

* Added confusion matrix doc

* Add auroc doc and fix titles

* Add average precision docs

* Added more documents for metrics

* Add index for user guide in side bar

* Minor patches (#542)

* Fix capitalization of Python

* Change ValueError to TypeError and update docstrings

* Add Precision-Recall Curve to experimental metrics (#544)

* Add ROC curve (#545)

* Add ROC metrics to experimental module

* fix typo

* Fix docstrings

* Add AUROC (#546)

* Add AUROC metric to experimental module

* Refactor binary and multiclass ROC functions

* Refactor tests to use a common thresholds list

* Fix mypy error

* Add regression metrics (#547)

* Add regression support

* update docstrings

* Ignore `no-any-return` errors

* Integrate experimental metrics with other modules (#549)

* integrate experimental metrics with other modules

* add average precision metric to experimental metrics package

* fix tutorials

* Add type hints and keyword arguments to metrics classes

* Update nbsphinx version to 0.9.3

* Update nbconvert version to 7.14.2

* Fix type annotations and formatting issues

* Update kernel display name in mortality_prediction.ipynb

* Add guard clause to prevent module execution on import

* Update `torch_distributed.py` with type hints

* Add multiclass and multilabel average precision metrics

* Change jupyter kernel

* Fix type annotations for metric values in ClassificationPlotter

---------

Co-authored-by: Amrit K <amritk@vectorinstitute.ai>

* Changed documentation theme to sphinx-book-theme

* Don't update deps

* Pre-commit fixes

* Add doc for ROC Curve

* Fix footer in docs

* Bump to 0.2.3

Signed-off-by: Amrit Krishnan <amrit110@gmail.com>

* Add logo and css fixes

* Fix formatting of conf.py file

* Small fix

* Move evaluation metrics docs under API reference

* Fix poetry build

* Improve documentation structure

* Formatting fixes

---------

Signed-off-by: Amrit Krishnan <amrit110@gmail.com>
Co-authored-by: Franklin <41602287+fcogidi@users.noreply.github.com>
Co-authored-by: Amrit K <amritk@vectorinstitute.ai>
Co-authored-by: Amrit Krishnan <amrit110@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Refactor existing code, with same or similar functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant