Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer generator over list #555

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

hoxell
Copy link
Collaborator

@hoxell hoxell commented Feb 18, 2024

PR Type ([Feature | Fix | Documentation | Test])

Fix, eh

Short Description

...

Tests Added

...

@hoxell hoxell requested a review from amrit110 February 18, 2024 16:43
Copy link
Member

@amrit110 amrit110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice, thanks

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1ca767) 70.71% compared to head (82727b0) 70.71%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #555   +/-   ##
=======================================
  Coverage   70.71%   70.71%           
=======================================
  Files         126      126           
  Lines       11224    11224           
=======================================
  Hits         7937     7937           
  Misses       3287     3287           
Files Coverage Δ
cyclops/data/df/vectorized.py 67.43% <100.00%> (ø)

Impacted file tree graph

@amrit110 amrit110 merged commit d1b5bcb into VectorInstitute:main Feb 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants