Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Matthews Correlation Coefficient #561

Merged
merged 22 commits into from
Mar 5, 2024
Merged

Add Matthews Correlation Coefficient #561

merged 22 commits into from
Mar 5, 2024

Conversation

fcogidi
Copy link
Collaborator

@fcogidi fcogidi commented Feb 21, 2024

PR Type

Feature/Fix.

Short Description

  • Add Matthews Correlation Coefficient.
  • Refactor some tests.

Tests Added

tests/cyclops/evaluate/metrics/experimental/test_matthews_corr_coef.py

@fcogidi fcogidi added enhancement New feature or request refactor Refactor existing code, with same or similar functionality labels Feb 21, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 97.72727% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 70.91%. Comparing base (e92bcca) to head (fe5c8c1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
+ Coverage   70.70%   70.91%   +0.21%     
==========================================
  Files         126      128       +2     
  Lines       11220    11308      +88     
==========================================
+ Hits         7933     8019      +86     
- Misses       3287     3289       +2     
Files Coverage Δ
.../evaluate/metrics/experimental/confusion_matrix.py 98.71% <ø> (ø)
...rics/experimental/functional/matthews_corr_coef.py 100.00% <100.00%> (ø)
...valuate/metrics/experimental/matthews_corr_coef.py 100.00% <100.00%> (ø)
cyclops/utils/index.py 100.00% <100.00%> (ø)
...etrics/experimental/functional/confusion_matrix.py 88.20% <60.00%> (-0.82%) ⬇️

Impacted file tree graph

@fcogidi fcogidi merged commit b22c555 into main Mar 5, 2024
10 checks passed
@fcogidi fcogidi deleted the add_mcc branch March 5, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Refactor existing code, with same or similar functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants