Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if values is none before iterating over it #674

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

hoxell
Copy link
Collaborator

@hoxell hoxell commented Aug 16, 2024

PR Type ([Feature | Fix | Documentation | Test])

Initial fIx for #632, eh

Short Description

Check if value is none before iterating over it, eh.
It's a patch to prevent the crash, but I assume you'll want to fix this at the root and pass it an empty iterable instead of None, eh.

Tests Added

Nope, eh

@hoxell hoxell requested a review from amrit110 August 16, 2024 16:49
@amrit110 amrit110 merged commit e736116 into VectorInstitute:main Sep 4, 2024
4 checks passed
@hoxell hoxell deleted the check_if_values_is_none branch September 5, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants