Feat/bridge price shape #221
Conversation
size-limit report 📦
|
Velenir
left a comment
Velenir
left a comment
There was a problem hiding this comment.
- Shape changed, a bunch of tests that use MatchSnapshot broke. Change API_URL when running tests to see
- Since you are changing types, could you add
maxImpactparam togetQuotemethod? It was added in API at some point recently.
| | 'receivedDestAmount' | ||
| | 'receivedDestAmountBeforeFee' | ||
| | 'receivedDestUSD' | ||
| | 'receivedDestUSDBeforeFee' |
There was a problem hiding this comment.
Could you check if srcAmountBeforeFee and other props specific for BUY are also added?
There was a problem hiding this comment.
No, availableBridges doesn't include src* stuff
There was a problem hiding this comment.
All the src* props would be the same across all bridges in availableBridges. I don't know if it's worth increasing price response by duplicating them, but on the other hand it wouldn't be bad to have AvailablePrice equal to BridgePrice.
src/methods/delta/getBridgeInfo.ts
Outdated
| export type BridgeProtocolResponse = { | ||
| protocol: string; | ||
| displayName: string; | ||
| icon: string; // CDN URL |
There was a problem hiding this comment.
Not necessarily CDN, let's not limit ourselves 😉
Added 1216a51 |
I fixed the snapshot, but a bunch of tests are still failing, though none of them are related to my change (I hope) |
| /** @description Partner string */ | ||
| partner?: string; | ||
| /** @description Maximum price impact (in percentage) acceptable for the trade */ | ||
| maxImpact?: number; |
There was a problem hiding this comment.
Somehow I didn't notice it
Added 2936ff5
|
Could you also replace wherever we make requests with ?network= to ?chainId=. they all now work with plain |
Done 45018d2 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
2 participants
Updates BridgePrice types
Note
BridgePriceInfonow includesfastest,bestReturn,recommendedflagsAvailableBridgerefactored to includebridgeandbridgeInfo; carriesreceivedDest*fieldsAvailableBridgeand updates SDK surface insrc/index.tsBridgeProtocolResponsenow includesicongetQuoteacceptsmaxImpactandmaxUSDImpactnetworktochainIdinadapters,rates,spender,swapTxand update related docs/comments9.3.1Written by Cursor Bugbot for commit 8195608. This will update automatically on new commits. Configure here.