Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create venctl.rb #19

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Create venctl.rb #19

merged 1 commit into from
Jan 9, 2024

Conversation

dronenb
Copy link
Contributor

@dronenb dronenb commented Jan 9, 2024

Fixes #18

@zosocanuck zosocanuck self-requested a review January 9, 2024 19:43
zosocanuck
zosocanuck approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@zosocanuck zosocanuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zosocanuck
Copy link
Collaborator

@dronenb Looks like there a bunch of style/formatting issues that need to be resolved prior to merging. Can you take a look?

@dronenb
Copy link
Contributor Author

dronenb commented Jan 9, 2024

@zosocanuck I will take a look and rebase commits once issues are resolved.

@dronenb dronenb force-pushed the main branch 4 times, most recently from 2870e7c to 9d02064 Compare January 9, 2024 22:13
@dronenb
Copy link
Contributor Author

dronenb commented Jan 9, 2024

I think the formatting issues should be fixed now.

@zosocanuck zosocanuck merged commit 58657c4 into Venafi:main Jan 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zosocanuck zosocanuck zosocanuck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

venctl Homebrew Formula
2 participants
@dronenb @zosocanuck