Skip to content

Commit

Permalink
Merge pull request #45 from Venafi/small-revocation-worarround
Browse files Browse the repository at this point in the history
replace error with silent ignoring call
  • Loading branch information
mr-tron authored Mar 16, 2020
2 parents 4a2f4d8 + 3394560 commit 8f6a3c5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
8 changes: 2 additions & 6 deletions plugin/pki/env_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -534,13 +534,9 @@ func (e *testEnv) RevokeCertificate(t *testing.T, certId string) {
},
})

if err == nil {
t.Fatalf("revoke path is not implemented yet and should return error")
}
if err.Error() != "not implemented yet" {
t.Fatalf("error message should be not implemented yet not %s", err)
if err != nil {
t.Fatal(err)
}

}

func makeConfig(configString venafiConfigString) (roleData map[string]interface{}, err error) {
Expand Down
3 changes: 1 addition & 2 deletions plugin/pki/path_venafi_cert_revoke.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package pki

import (
"context"
"fmt"
"github.com/hashicorp/vault/logical"
"github.com/hashicorp/vault/logical/framework"
)
Expand Down Expand Up @@ -30,5 +29,5 @@ func pathVenafiCertRevoke(b *backend) *framework.Path {
}

func (b *backend) venafiCertRevoke(ctx context.Context, req *logical.Request, d *framework.FieldData) (*logical.Response, error) {
return nil, fmt.Errorf("not implemented yet")
return nil, nil
}

0 comments on commit 8f6a3c5

Please sign in to comment.