Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tokenURL attribute for VCP service account authentication #448

Merged
merged 6 commits into from
Apr 5, 2024

Conversation

rvelaVenafi
Copy link
Contributor

@rvelaVenafi rvelaVenafi commented Apr 4, 2024

VCert SDK:

  • Removes TenantID from endpoint.Authentication struct
  • Cloud connector will use endpoint.Authentication.OAuthProvider.TokenURL instead of building the URL using the tenantID to obtain the access token

VCert CLI:

  • Removes --tenant-id flag for getcred command
  • Adds --token-url flag for getcred command

VCert Playbook:

  • Removes tenantId attribute from config.connection.credentials object
  • Now uses config.connection.credentials.idP.tokenURL for VCP service account authentication

Enables the  use of tokenURL for VCP service account authentication. The tenantID attribute has been removed.
@rvelaVenafi rvelaVenafi requested a review from tr1ck3r as a code owner April 4, 2024 23:09
@rvelaVenafi rvelaVenafi merged commit 21228d0 into master Apr 5, 2024
3 checks passed
@rvelaVenafi rvelaVenafi deleted the token-url-attribute branch April 5, 2024 06:14
@BeardedPrincess
Copy link
Collaborator

@rvelaVenafi: Seems we updated the codepaths for this, but not the documentation / samples. Should I open an issue, or are you already aware of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants