Omnichain governance deployments #57
Conversation
helpers/deploy/deploymentUtils.ts
Outdated
| import bscTestnetGovernanceDeployments from "../../deployments/bsctestnet.json"; | ||
| import { SUPPORTED_NETWORKS } from "./constants"; | ||
|
|
||
| export const testnetNetworks = ["sepolia", "opbnbtestnet", "arbitrumsepolia"]; |
There was a problem hiding this comment.
| export const testnetNetworks = ["sepolia", "opbnbtestnet", "arbitrumsepolia"]; | |
| export const testnetNetworks = ["sepolia", "opbnbtestnet", "arbitrumsepolia", "hardhat"]; |
There was a problem hiding this comment.
Scripts are working fine on hardhat, we don't need this change we need this only here
helpers/deploy/deploymentUtils.ts
Outdated
| import bscTestnetGovernanceDeployments from "../../deployments/bsctestnet.json"; | ||
| import { SUPPORTED_NETWORKS } from "./constants"; | ||
|
|
||
| export const testnetNetworks = ["sepolia", "opbnbtestnet", "arbitrumsepolia"]; | ||
| const mainnetNetworks = ["ethereum", "opbnbmainnet", "arbitrumone"]; |
There was a problem hiding this comment.
| const mainnetNetworks = ["ethereum", "opbnbmainnet", "arbitrumone"]; | |
| const mainnetNetworks = ["ethereum", "opbnbmainnet", "arbitrumone", "hardhat"]; |
Is the quickest way to test this in development to deploy both sides of governance to hardhat? My thought is to start this way for testing/ subgraph testing and then iterate.
There was a problem hiding this comment.
Scripts are working fine on hardhat, we don't need this change.
There was a problem hiding this comment.
Correct the work fine but what we do loose without this change is deploying the target network contracts to hardhat which could be helpful for testing for example.
There was a problem hiding this comment.
We can still deploy target network contracts along with local network contracts on hardhat .
For hardhat it will take bscmainnet chain id by default, see here
LMK if I am missing something.
GitGuru7
force-pushed
the
feat/omnichain-governance-deployments
branch
from
ca57fb8 to
3ddf06d
Compare
helpers/deploy/constants.ts
Outdated
| hardhat: 10102, | ||
| }; | ||
|
|
||
| export const BNB_GUARDIAN = "0x1C2CAc6ec528c20800B2fe734820D87b581eAA6B"; |
There was a problem hiding this comment.
We could move this variable to deploy/003-omnichain-source.ts, where it's only used
helpers/deploy/deploymentUtils.ts
Outdated
|
|
||
| export const getSourceChainId = async (network: SUPPORTED_NETWORKS) => { | ||
| if (testnetNetworks.includes(network as string)) { | ||
| return 10102; |
There was a problem hiding this comment.
We could use the constant LZ_CHAINID.bsctestnet?
Description
Resolves #