[VEN-2661]: Tool to fetch permissions granted by ACM on all supporting chains #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web3rover
approved these changes
Jul 15, 2024
chechu
reviewed
Aug 19, 2024
|
|
||
| const { permissions: existingPermissions } = this.getPermissionsJson(); | ||
| this.existingPermissions = existingPermissions; | ||
| this.blocksParsed = this.getLastBlockNumber(); |
There was a problem hiding this comment.
Do we need this function? I think getPermissionsJson returns the height stored in the permissions file, or the default value
| } | ||
|
|
||
| private getHash(contractAddress: string, functionSignature: string): string { | ||
| const hash = ethers.utils.solidityKeccak256(["string", "string"], [contractAddress, functionSignature]); |
There was a problem hiding this comment.
Why are we using here ["string", "string"] instead of ["address", "string"] as we are doing in line 170. Moreover, could we use getHash in line 170, instead of solidityPack + keccak256?
Magkoooh
approved these changes
Dec 12, 2024
Magkoooh
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on the given network all the permissions that are granted by ACM (and not yet revoked) by ACM is generated in scripts/ACMPermissions//networks/<network_name>/permissions.md
To interact with the tool, use this command
npx hardhat run scripts/ACMPermissions/index.ts --network <network_name>Resolves VEN-2661