Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add empty project skeleton #1

Merged
merged 11 commits into from
Jan 16, 2024
Merged

feat: add empty project skeleton #1

merged 11 commits into from
Jan 16, 2024

Conversation

kkirka
Copy link
Contributor

@kkirka kkirka commented Dec 14, 2023

Add the project skeleton with some common tooling installed.

The plan is to:

  • use hardhat/ethers-v5/typechain for testing purposes – we already have this setup in other repos, and although it's a bit outdated, it would be easier to keep projects in sync
  • use viem for scripts – it's optimized for this purpose, contains built-in multicall and fallback nodes support, and doesn't require any complex config to just work

- name: Check linting of solidity and typescript
run: yarn lint

test:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job could probable get skipped and turned back on when tests are added

@@ -1,2 +1 @@
# Keeper bots for Venus Protocol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a short description

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Co-authored-by: Corey Rice <7258308+coreyar@users.noreply.github.com>
templates: "./docgen-templates",
},
external: {
deployments: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do here something similar to this: VenusProtocol/venus-protocol#408

@coreyar coreyar force-pushed the feat/skeleton branch 3 times, most recently from cc9bfa1 to a3d5685 Compare January 16, 2024 11:55
@coreyar coreyar self-requested a review January 16, 2024 12:02
@coreyar coreyar self-requested a review January 16, 2024 15:03
@kkirka kkirka merged commit e347798 into main Jan 16, 2024
4 checks passed
@kkirka kkirka deleted the feat/skeleton branch January 16, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants