[VEN-2299]: add a contract to operate token converters #3

kkirka · 2023-12-20T13:30:18Z

No description provided.

coreyar · 2024-01-18T14:10:37Z

package.json

-    "@venusprotocol/protocol-reserve": "1.0.0-converters.1",
-    "@venusprotocol/venus-protocol": "6.1.0-dev.8"
+    "@venusprotocol/protocol-reserve": "1.3.0-dev.1",
+    "@venusprotocol/venus-protocol": "6.1.0-dev.8",


Can we use release versions?
@venusprotocol/protocol-reserve - 1.2.0
@venusprotocol/venus-protocol - 7.0.0

Not sure about protocol-reserve, but we can definitely use core v7. I'll update the other ones as well.

coreyar · 2024-01-18T14:11:13Z

src/config/abis/TokenConverterOperator.ts

@@ -0,0 +1,227 @@
+// @kkirka: This is a typescript file and not a JSON file because I wanted to keep


I would recommend using typechain and getting abis from packages

Typechain devs say it's going to die at some point: https://github.com/dethcrypto/TypeChain?tab=readme-ov-file#soft-deprecation-notice, and I'm not sure typechain types are compatible with viem.

Actually this file is just export default <ABI JSON> as const;, so it should be straightforward to import ABIs from packages and "decorate" them this way.

Well, you can't create a const from imported JSON. It looks like HasAddressFor isn't working as expected for this reason.

I've started working on a postinstall step where we generate EIP-712 using the wagmi/cli hardhat plugin

Weird, HasAddressFor worked for me because importing JSON yields a pretty narrow type when JSON is an object (not as narrow as const but still). Maybe it failed because governance-contracts was missing? I've added it here: 77064f9

Still, wagmi/cli sounds good, as long as you're ok with using viem

coreyar · 2024-01-18T14:12:09Z

src/config/addresses.ts

+import bsctestnetCore from "@venusprotocol/venus-protocol/deployments/bsctestnet_addresses.json";
+
+export const addresses = {
+  // TODO: Replace hardcoded addresses with addresses from the packages


Is something missing to complete this todo

Yeah, the PR with the converters isn't merged yet, even to dev: VenusProtocol/protocol-reserve#9

coreyar · 2024-01-18T14:21:54Z

src/converter-bot/path.ts

+  readonly hex: Hex;
+}
+
+export const parsePath = (data: Array<Address | number>): Path => {


nit: An idea to make this safer would be accept an input like Array<[address, number, address]>. Since each part of the path will have the same 3 parts

Yeah, I didn't like Address | number either as it doesn't really convey the shape of the expected input.

The path goes like:
[USDT, 0.5%, WBNB, 0.3%, BTC, 0.1%, XVS]

Do you propose to instead use this kind of path:
[[USDT, 0.5%, WBNB], [WBNB, 0,3%, BTC], [BTC, 0.1%, XVS]]?

It seemed too verbose to me at first, but now I think that maybe it's more readable 🤔

coreyar · 2024-01-18T14:25:00Z

src/converter-bot/tokenConverterBot.ts

+  }
+
+  get publicClient() {
+    return this._publicClient ?? getPublicClient(this.chainName);


this._publicClient never receives an assignment. Why not set this in the constructor?

Oups, I wanted some sort of laziness here, but actually did it wrong, lol 🤦 😅

The intent was sth like

get publicClient() { if (!this._publicClient) { this._publicClient = getPublicClient(this.chainName); } return this._publicClient; }

Maybe there are better ways to lazily initialize things? Some lib or a common approach (memoization, whatever)

You could use the logical or assignment operator ||=

coreyar · 2024-01-18T14:25:16Z

src/converter-bot/tokenConverterBot.ts

+  }
+
+  get walletClient() {
+    return this._walletClient ?? getWalletClient(this.chainName);


this._walletClient never receives an assignment

Yeah, same thing as with public client

coreyar · 2024-01-18T14:29:42Z

src/converter-bot/tokenConverterBot.ts

+    const beneficiary = this.walletClient.account.address;
+    const chain = chains[this.chainName];
+
+    if (minIncome < 0n) {


Why would minIncome be negative?

Sometimes we're willing to pay for conversions to happen, even if it's not profitable. Actually in the initial phase the incentives would be zero, so we'll probably be paying for all conversions.

coreyar · 2024-01-18T19:44:33Z

src/config/clients.ts

+): WalletClient<HttpTransport, typeof chains[ChainT], PrivateKeyAccount> => {
+  return createWalletClient({
+    chain: chains[chainName],
+    transport: http(process.env[`LIVE_NETWORK_${chainName}`]),


This env var is missing from the example

coreyar · 2024-01-18T19:44:54Z

src/config/clients.ts

+};
+
+const readPrivateKeyFromEnv = (chainName: string): PrivateKeyAccount => {
+  const key = process.env[`PRIVATE_KEY_${chainName}`];


This env var is missing from the example

kkirka changed the base branch from main to feat/move-debt-operator December 20, 2023 13:30

kkirka force-pushed the feat/converter-operator branch from ed00401 to 93b043e Compare December 22, 2023 11:38

chechu changed the title ~~feat: add a contract to operate token converters~~ [VEN-2299]: add a contract to operate token converters Jan 11, 2024

kkirka force-pushed the feat/converter-operator branch from cd0dd1b to 08512c8 Compare January 18, 2024 10:53

coreyar reviewed Jan 18, 2024

View reviewed changes

kkirka added 2 commits January 25, 2024 16:56

feat: use production package versions

23a85c7

feat: add flash swap helper

47c5dbf

kkirka force-pushed the feat/converter-operator branch from 08512c8 to 742773f Compare January 25, 2024 14:05

kkirka changed the base branch from feat/move-debt-operator to main January 25, 2024 14:06

coreyar approved these changes Jan 25, 2024

View reviewed changes

kkirka force-pushed the feat/converter-operator branch from a60912c to 77064f9 Compare January 25, 2024 14:17

kkirka added 3 commits January 25, 2024 17:25

feat: add token converter operator contract

fb41616

feat: allow specifying min income or slippage buffer

6070916

feat: add a bot for token converter arbitrage

3418642

kkirka force-pushed the feat/converter-operator branch from 77064f9 to 3418642 Compare January 25, 2024 14:25

kkirka merged commit b3d3c3f into main Jan 25, 2024

kkirka deleted the feat/converter-operator branch January 25, 2024 14:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[VEN-2299]: add a contract to operate token converters #3

[VEN-2299]: add a contract to operate token converters #3

kkirka commented Dec 20, 2023

coreyar Jan 18, 2024

kkirka Jan 18, 2024

kkirka Jan 25, 2024

coreyar Jan 18, 2024

kkirka Jan 18, 2024

coreyar Jan 19, 2024

kkirka Jan 25, 2024

coreyar Jan 18, 2024 •

edited

Loading

kkirka Jan 18, 2024

kkirka Jan 25, 2024

coreyar Jan 18, 2024

kkirka Jan 18, 2024 •

edited

Loading

coreyar Jan 18, 2024

kkirka Jan 18, 2024

kkirka Jan 18, 2024 •

edited

Loading

coreyar Jan 19, 2024

kkirka Jan 25, 2024

coreyar Jan 18, 2024

kkirka Jan 18, 2024

kkirka Jan 25, 2024

coreyar Jan 18, 2024

kkirka Jan 18, 2024

coreyar Jan 18, 2024

coreyar Jan 18, 2024

		@@ -0,0 +1,227 @@
		// @kkirka: This is a typescript file and not a JSON file because I wanted to keep

[VEN-2299]: add a contract to operate token converters #3

[VEN-2299]: add a contract to operate token converters #3

Conversation

kkirka commented Dec 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coreyar Jan 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kkirka Jan 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kkirka Jan 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coreyar Jan 18, 2024 •

edited

Loading

kkirka Jan 18, 2024 •

edited

Loading

kkirka Jan 18, 2024 •

edited

Loading