refactor: remove bscmainnet deployments from hardhat deployments #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreyar
force-pushed
the
remove-bscmainnet-addresses-from-hardhat-deployment
branch
3 times, most recently
from
35fdee7 to
feecb95
Compare
chechu
reviewed
Dec 19, 2024
chechu
reviewed
Dec 19, 2024
chechu
previously approved these changes
Dec 19, 2024
coreyar
force-pushed
the
remove-bscmainnet-addresses-from-hardhat-deployment
branch
from
feecb95 to
d35fb75
Compare
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of using
bscmainnetaddresses in the hardhat deployment, this PR adds a setup script.I think we can improve this further by using the
deploymentkey in the external contracts config but currently it has error compiling related to typescript declaration files