[VEN-2212]: Fix for MAX_PERCENT in PSR #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chechu
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
The function getPercentageDistribution returns the percentage, but typed as a uint256. I understand we don't need to change anything, and it's not a breaking change, because the legacy uint8 was casted to uint256 and the new uint16 will be casted also to uint256
web3rover
approved these changes
Dec 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains fix regarding
MAX_PERCENTused when executingaddOrUpdateDistributionConfigs()for defining the percentage to transfer amounts to destinations.Resolves #VEN-2212