Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add copy addresses and contract links to market page #3669

Merged
merged 10 commits into from
Jan 3, 2025
Merged

feat: add copy addresses and contract links to market page #3669

merged 10 commits into from
Jan 3, 2025

Conversation

gleiser-oliveira
Copy link
Contributor

@gleiser-oliveira gleiser-oliveira commented Dec 24, 2024 •
edited
Loading

Jira ticket(s)

VEN-2938

Changes

  • Most of the changes are related to snapshots, because I moved the token assets to a new folder, they are now separated as img/underlyingTokens and img/vTokens
  • Decoupled the Dropdown component from the Select component, allowing it to be used in the new copy/add to wallet and contract link options
  • Added VToken assets
  • Added the new dropdown components to the Market page

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 24, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 0c8359c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@venusprotocol/evm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
app-alt.venus.io ✅ Ready (Inspect) Visit Preview Jan 3, 2025 2:39pm
dapp-preview ✅ Ready (Inspect) Visit Preview Jan 3, 2025 2:39pm
dapp-testnet ✅ Ready (Inspect) Visit Preview Jan 3, 2025 2:39pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
venus.io ⬜️ Skipped (Inspect) Jan 3, 2025 2:39pm

@gleiser-oliveira gleiser-oliveira force-pushed the feat/copy-addresses-and-contract-links branch from 69b1f65 to 8830a78 Compare December 26, 2024 13:57
@vercel vercel bot temporarily deployed to Preview – venus.io December 26, 2024 13:58 Inactive
@gleiser-oliveira gleiser-oliveira force-pushed the feat/copy-addresses-and-contract-links branch from 8830a78 to d5e8407 Compare December 26, 2024 14:12
@vercel vercel bot temporarily deployed to Preview – venus.io December 26, 2024 14:12 Inactive
@gleiser-oliveira gleiser-oliveira force-pushed the feat/copy-addresses-and-contract-links branch from d5e8407 to a87cf54 Compare December 26, 2024 14:53
@vercel vercel bot temporarily deployed to Preview – venus.io December 26, 2024 14:54 Inactive
@gleiser-oliveira gleiser-oliveira force-pushed the feat/copy-addresses-and-contract-links branch from a87cf54 to 5a6e028 Compare December 26, 2024 15:03
@vercel vercel bot temporarily deployed to Preview – venus.io December 26, 2024 15:03 Inactive
@gleiser-oliveira gleiser-oliveira force-pushed the feat/copy-addresses-and-contract-links branch from 5a6e028 to 5b90fd4 Compare December 26, 2024 16:00
@vercel vercel bot temporarily deployed to Preview – venus.io December 26, 2024 16:00 Inactive
@vercel vercel bot temporarily deployed to Preview – venus.io December 31, 2024 06:59 Inactive
therealemjy
therealemjy reviewed Dec 31, 2024
View reviewed changes
apps/evm/src/libs/tokens/infos/vTokens/bscTestnet.ts
Comment on lines +79 to +82
// [venusProtocolBscTestnetDeployments.addresses.vAAVE.toLowerCase()]: vAaveCoreLogo,
// [venusProtocolBscTestnetDeployments.addresses.vADA.toLowerCase()]: vAdaCoreLogo,
// [venusProtocolBscTestnetDeployments.addresses.vBCH.toLowerCase()]: vBchCoreLogo,
// [venusProtocolBscTestnetDeployments.addresses.vBETH.toLowerCase()]: vBethCoreLogo,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testnet deployment has many VTokens missing, but I reported this and it's getting added here VenusProtocol/venus-protocol#544

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks for getting this updated.

apps/evm/src/containers/Layout/Header/MarketInfo/AddTokenToWalletDropdown/index.tsx Outdated Show resolved Hide resolved
apps/evm/src/components/Dropdown/index.tsx Outdated
Comment on lines 49 to 64
{
className,
children,
buttonClassName,
options,
value,
onChange,
onBlur,
label,
placeLabelToLeft = false,
size = 'medium',
variant = 'primary',
menuTitle,
menuPosition = 'left',
...otherProps
}: DropdownProps<TValue>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed this comment

therealemjy
therealemjy reviewed Dec 31, 2024
View reviewed changes
Copy link
Member

@therealemjy therealemjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've lost the hover effect on dropdown options on the Market page:
Screenshot 2024-12-31 at 09 55 19

Because the padding was removed from the Dropdown content tag, you'll need to add it to the options of existing dropdowns within the dApp:
Screenshot 2024-12-31 at 09 54 40

Screenshot 2024-12-31 at 10 03 02

On the Proposal list, the dropdown to filter by state now shows an unstyled input:
Screenshot 2024-12-31 at 10 03 02

@vercel vercel bot temporarily deployed to Preview – venus.io December 31, 2024 16:01 Inactive
@gleiser-oliveira gleiser-oliveira force-pushed the feat/copy-addresses-and-contract-links branch from 960920d to 530955c Compare January 2, 2025 06:45
@vercel vercel bot temporarily deployed to Preview – venus.io January 2, 2025 06:45 Inactive
@gleiser-oliveira gleiser-oliveira force-pushed the feat/copy-addresses-and-contract-links branch from 530955c to 84c2cb6 Compare January 2, 2025 17:49
@vercel vercel bot temporarily deployed to Preview – venus.io January 2, 2025 17:49 Inactive
therealemjy
therealemjy approved these changes Jan 3, 2025
View reviewed changes
apps/evm/src/components/Dropdown/types.ts Outdated
@@ -0,0 +1,23 @@
import type { CardProps } from 'components/Card';

export interface DropdownProps extends Omit<CardProps, 'onChange' | 'children'> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CardProps type can be removed here. Otherwise the Dropdown component takes an asChild prop that has no effect.

apps/evm/src/components/DropdownToggleButton/index.tsx Outdated
Copy link
Member

@therealemjy therealemjy Jan 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this component is only shared by the AddTokenToWalletDropdown and GoToTokenContractDropdown components, it should be contained in their parent directory.

@gleiser-oliveira gleiser-oliveira force-pushed the feat/copy-addresses-and-contract-links branch from 84c2cb6 to 0c8359c Compare January 3, 2025 14:34
@vercel vercel bot temporarily deployed to Preview – venus.io January 3, 2025 14:34 Inactive
@gleiser-oliveira gleiser-oliveira merged commit 5252157 into main Jan 3, 2025
9 checks passed
@gleiser-oliveira gleiser-oliveira deleted the feat/copy-addresses-and-contract-links branch January 3, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealemjy therealemjy therealemjy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gleiser-oliveira @therealemjy