End to end subcircuit soundness #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
commented
Jan 10, 2025
Comment on lines
-12
to
+6
| #eval! | ||
| #eval |
There was a problem hiding this comment.
could remove ! because there's no sorry left!
mitschabaude
commented
Jan 10, 2025
Comment on lines
+64
to
+69
| | case2 ops _ ih | case3 ops _ ih | case4 ops _ ih | case5 ops _ ih => | ||
| dsimp only [to_flat_operations] at h | ||
| generalize to_flat_operations ops = flatops at h ih | ||
| cases ops | ||
| <;> cases flatops | ||
| <;> try dsimp only [constraints_hold, constraints_hold_from_list] at h; tauto |
There was a problem hiding this comment.
fanciest proof I did so far, the final tactic is applied to 4 * 2 * 2 = 16 cases at once 😄
gio54321
approved these changes
Jan 11, 2025
| cases v | ||
| cases w | ||
| simp [Subtype.mk_eq_mk] at h | ||
| simp [h] |
There was a problem hiding this comment.
Didn't know about ext, very nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #37
Vectorsorryproofs in the core lib!