Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/get nb jobs #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/get nb jobs #44

wants to merge 2 commits into from

Conversation

poojaVeritas
Copy link
Collaborator

rkennedy
rkennedy requested changes Aug 4, 2020
View reviewed changes
Copy link
Collaborator

@rkennedy rkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine. Everything could use a little cleanup, though. Please remove the .DS_Store file from the PR.

snippets/go/src/nb_jobs/README.md
Also, returns all the NetBackup jobs of the jobType 'Backup'


#######Use following command to execute the program
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use markdown to format the readme. For example, # designates headings and indentation or backticks designate code.

snippets/go/src/nb_jobs/get-nb-jobs.go
//##############################################################
func GetHTTPClient() *http.Client {
tlsConfig := &tls.Config {
InsecureSkipVerify: true, //for this test, ignore ssl certificate
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not just for this test. It's pretty standard to disable certificate validation in all NetBackup communication because the certificate is self-signed and thus unverifiable anyway. I think you can just remove the comment because it's not really indicating anything special about this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkennedy rkennedy rkennedy requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poojaVeritas @rkennedy