-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incremental draft #174
Draft
treblereel
wants to merge
4
commits into
Vertispan:main
Choose a base branch
from
treblereel:incremental_draft
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Incremental draft #174
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
321 changes: 315 additions & 6 deletions
321
build-caching/src/main/java/com/vertispan/j2cl/build/BuildService.java
Large diffs are not rendered by default.
Oops, something went wrong.
36 changes: 36 additions & 0 deletions
36
build-caching/src/main/java/com/vertispan/j2cl/build/ChangedAcceptor.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
package com.vertispan.j2cl.build; | ||
|
||
import java.util.function.Predicate; | ||
|
||
import com.vertispan.j2cl.build.incremental.BuildMap; | ||
import com.vertispan.j2cl.build.task.CachedPath; | ||
import io.methvin.watcher.hashing.FileHash; | ||
|
||
public class ChangedAcceptor implements Predicate<CachedPath> { | ||
private BuildMap buildMap; | ||
|
||
public ChangedAcceptor(Project project, BuildService buildService) { | ||
|
||
|
||
buildMap = buildService != null ? buildService.getBuildMaps().get(project) : null; | ||
} | ||
|
||
@Override public boolean test(CachedPath cachedPath) { | ||
boolean found = true; | ||
if (buildMap != null) { | ||
String tested = cachedPath.getSourcePath().toString(); | ||
if(tested.endsWith(".native.js")) { | ||
String candidate = tested.replace(".native.js",".java"); | ||
if(buildMap.getChangedFiles().contains(candidate)) { | ||
return true; | ||
} | ||
} | ||
|
||
found = cachedPath.getHash().equals(FileHash.DIRECTORY) || | ||
buildMap.getChangedFiles().contains(cachedPath.getSourcePath().toString()); | ||
} | ||
|
||
return found; | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
build-caching/src/main/java/com/vertispan/j2cl/build/ProjectFiles.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
package com.vertispan.j2cl.build; | ||
|
||
import java.util.*; | ||
|
||
public class ProjectFiles { | ||
private String dir; | ||
|
||
private List<String> removed = new ArrayList<>(); // files | ||
private Map<String, Boolean> updated = new HashMap<>(); // files | ||
private Set<String> added = new HashSet<>(); // files | ||
private Set<String> all; // files | ||
|
||
public ProjectFiles(String dir, Set<String> all) { | ||
this.dir = dir; | ||
this.all = all; | ||
} | ||
|
||
public String getDir() { | ||
return dir; | ||
} | ||
|
||
public List<String> getRemoved() { | ||
return removed; | ||
} | ||
|
||
public Map<String, Boolean> getUpdated() { | ||
return updated; | ||
} | ||
|
||
public Set<String> getAdded() { | ||
return added; | ||
} | ||
|
||
public Set<String> getAll() { | ||
return all; | ||
} | ||
|
||
@Override public String toString() { | ||
return "ProjectFiles{" + | ||
"removed=" + removed + | ||
", updated=" + updated.keySet() + | ||
", added=" + added + | ||
", all=" + all + | ||
'}'; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hard coded this here, as a hack. imho the writeFilesDat should be in it's own leaf task, only called once all other tasks are done.