feat: Implement periodic vesting steps (Issue #14)#102
Merged
JerryIdoko merged 2 commits intoVesting-Vault:mainfrom Feb 26, 2026
Merged
feat: Implement periodic vesting steps (Issue #14)#102JerryIdoko merged 2 commits intoVesting-Vault:mainfrom
JerryIdoko merged 2 commits intoVesting-Vault:mainfrom
Conversation
- Add step_duration parameter for periodic vesting schedules - Implement step function calculation with rounding down to nearest month - Add helper functions for common time durations (monthly, quarterly, yearly) - Create comprehensive test suite for periodic vesting functionality - Fix duplicate struct definitions and broken functions - Add detailed documentation and usage examples Acceptance Criteria: ✅ If step_duration > 0, calculate vested = (elapsed / step_duration) * rate * step_duration ✅ Round down to the nearest month This enables both linear (step_duration = 0) and periodic (step_duration > 0) vesting while maintaining backward compatibility with existing vaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14
Acceptance Criteria:
✅ If step_duration > 0, calculate vested = (elapsed / step_duration) * rate * step_duration ✅ Round down to the nearest month
This enables both linear (step_duration = 0) and periodic (step_duration > 0) vesting while maintaining backward compatibility with existing vaults.