Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OffsetArrays ambiguity resolution again #8

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

yha
Copy link
Contributor

@yha yha commented Nov 15, 2020

Since JuliaArrays/OffsetArrays.jl#157, OffsetArrays.OffsetAxisKnownLength == Base.DimOrInd, so the ambiguity-resolving method from #1 overwrites the earlier similar method, triggering a warning. This simply removes the method, which is not needed anymore.
For this to work, OffsetArrays needs to be at version >=1.3, so I keep it as a dependency with a comment in Project.toml (comments in Project.toml are not preserved by Pkg operations unfortunately, but I think it's still better than no comment).

@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #8 (dfa4db9) into master (2fd9f4b) will increase coverage by 5.26%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master        #8      +/-   ##
===========================================
+ Coverage   94.73%   100.00%   +5.26%     
===========================================
  Files           1         1              
  Lines          19        18       -1     
===========================================
  Hits           18        18              
+ Misses          1         0       -1     
Impacted Files Coverage Δ
src/CircularArrays.jl 100.00% <ø> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd9f4b...dfa4db9. Read the comment docs.

@Vexatos
Copy link
Owner

Vexatos commented Nov 16, 2020

This is good news. Isn't it possible to keep the [compat] declaration, but remove the dependency (or change it to tests-only in [extras])? Or would that allow installing it with an outdated version of OffsetArrays?

Edit: Just noticed that removing the dependency entirely while keeping the compat entry does indeed not work, which is unfortunate.

@Vexatos
Copy link
Owner

Vexatos commented Nov 16, 2020

I guess I'll have to keep the dependency, at least for now. Will be able to remove it in the future, but this at least resolves #3 partially. Thank you!

@Vexatos Vexatos merged commit fee589b into Vexatos:master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants