Added translation to cog "birthday" #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to edit "commands.py" to be able to generate "messages.pot" also added the spanish translation
|
Hey, thanks for the PR. I'm not currently interested in the ongoing maintenance burden of supporting translations. You can of course run the translations you created on your own bot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope it's okay with you, but I wanted to translate this cog to spanish, without prior knowledge of python, I think I managed to do it as it's working now on my server, but I'm pretty sure it could be done better. The issue was the fstrings had to be changed, so I did, but you're welcome to edit and revise all to your liking.
I added already the messages.pot file and the es-ES.po file ready to be used.
Let me know if you want any information or you want to change anything. And sorry if any mistakes done, as I said, I didn't even know anything about python just 3 days ago...