Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update viaversion deps for 1.21+ #240

Merged
merged 5 commits into from
Nov 14, 2024
Merged

update viaversion deps for 1.21+ #240

merged 5 commits into from
Nov 14, 2024

Conversation

RoblKyogre
Copy link
Contributor

  • updated via* dependencies to their latest versions as of today and added 1.21+ options to the web page
  • removed PreNettyBaseProtocol lines in src/main/kotlin/com/viaversion/aas/handler/BackEndInit.kt, as the ViaLegacy API seems to no longer require it as of ViaVersion/ViaLegacy@7f1cb82
  • changed ViaAprilFools dependency to be in-line with the other via* dependencies (viaversion, viabackwards, viarewind), as it now gets updated under viaaprilfools-common

FlorianMichael
FlorianMichael reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@FlorianMichael FlorianMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are alright themselves, but without properly updating the VIAaaS networking code this won't have much affect, will it?

FlorianMichael
FlorianMichael approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@FlorianMichael FlorianMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for now

@FlorianMichael FlorianMichael merged commit 2669945 into ViaVersion:master Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianMichael FlorianMichael FlorianMichael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoblKyogre @FlorianMichael