support grpc endpoint #59
Open
+109,096
−142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JayiceZ <1185430411@qq.com>
Signed-off-by: JayiceZ <1185430411@qq.com>
JayiceZ
commented
Oct 1, 2025
|
|
||
| _, err = bb.ReadFrom(r.Body) | ||
| if err != nil { | ||
| WriteErrorGrpcResponse(w, GrpcInvalidArgument, fmt.Sprintf("cannot read request body: %s", err)) |
There was a problem hiding this comment.
refer https://github.com/grpc/grpc/blob/master/doc/statuscodes.md
I think we should use GrpcInternal .
|
|
||
| err = checkProtobufRequest(bb.B) | ||
| if err != nil { | ||
| WriteErrorGrpcResponse(w, GrpcInvalidArgument, err.Error()) |
There was a problem hiding this comment.
Same as above, the docs said that we should return GrpcInternal when Error parsing request proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Please provide a brief description of the changes you made. Be as specific as possible to help others understand the purpose and impact of your modifications.
Checklist
The following checks are mandatory: