Merge pull request #509 from github/eager-load-compile

Eager load compile
ViewComponent · Oct 23, 2020 · 0fb9daa · 0fb9daa
2 parents 57dc526 + bd128b6
commit 0fb9daa
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## master
 
+* Only compile components at application initialization if eager loading is enabled.
+
+    *Joel Hawksley*
+
 ## 2.20.0
 
 * Don't add `/test/components/previews` to preview_paths if directory doesn't exist.

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -86,7 +86,7 @@ GIT
 PATH
   remote: .
   specs:
-    view_component (2.19.1)
+    view_component (2.20.0)
       activesupport (>= 5.0.0, < 7.0)
 
 GEM

diff --git a/lib/view_component/engine.rb b/lib/view_component/engine.rb
@@ -44,7 +44,7 @@ class Engine < Rails::Engine # :nodoc:
 
     initializer "view_component.eager_load_actions" do
       ActiveSupport.on_load(:after_initialize) do
-        ViewComponent::Base.descendants.each(&:compile)
+        ViewComponent::Base.descendants.each(&:compile) if Rails.application.config.eager_load
       end
     end