Skip to content

Commit

Permalink
Merge pull request #35 from github/older-ruby-rails
Browse files Browse the repository at this point in the history
support ruby 2.3 / Rails 5.0
  • Loading branch information
joelhawksley authored Aug 28, 2019
2 parents 5d5cd29 + 2f1f274 commit cee6871
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 9 deletions.
15 changes: 12 additions & 3 deletions .github/workflows/ruby_on_rails.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,17 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
rails_version: ["5.2.3", "6.0.0", "master"]
ruby_version: ["2.5.x", "2.6.x"]
rails_version: [5.0.0, 5.2.3, 6.0.0, master]
ruby_version: [2.3.x, 2.4.x, 2.5.x, 2.6.x]
exclude:
- rails_version: master
ruby_version: 2.4.x
- rails_version: master
ruby_version: 2.3.x
- rails_version: 6.0.0
ruby_version: 2.4.x
- rails_version: 6.0.0
ruby_version: 2.3.x
steps:
- uses: actions/checkout@master
- name: Setup Ruby
Expand All @@ -17,7 +26,7 @@ jobs:
version: ${{ matrix.ruby_version }}
- name: Build and test with Rake
run: |
gem install bundler
gem install bundler:1.14.0
bundle update
bundle install --jobs 4 --retry 3
bundle exec rake
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
* `actionview-component` is now tested against Ruby 2.3/2.4 and Rails 5.0.0.

# v1.2.0

* The `render_component` test helper has been renamed to `render_inline`. `render_component` has been deprecated and will be removed in v2.0.0.
Expand Down
6 changes: 3 additions & 3 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ GEM
mimemagic (0.3.3)
mini_mime (1.0.2)
mini_portile2 (2.4.0)
minitest (5.11.3)
minitest (5.1.0)
nio4r (2.4.0)
nokogiri (1.10.4)
mini_portile2 (~> 2.4.0)
Expand Down Expand Up @@ -149,12 +149,12 @@ DEPENDENCIES
actionview-component!
bundler (>= 1.14)
haml (~> 5)
minitest (~> 5.0)
minitest (= 5.1.0)
rails (= 5.2.3)
rake (~> 10.0)
rubocop (~> 0.59)
rubocop-github (~> 0.13.0)
slim (~> 4.0)

BUNDLED WITH
2.0.2
1.17.3
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Preliminary support for rendering components was merged into Rails `6.1.0.alpha`

## Compatibility

`actionview-component` is tested for compatibility with all combinations of Ruby `2.5`/`2.6` and Rails `5.2.3`/`6.0.0`/`6.1.0.alpha`.
`actionview-component` is tested for compatibility with combinations of Ruby `2.3`/`2.4`/`2.5`/`2.6` and Rails `5.0.0`/`5.2.3`/`6.0.0`/`6.1.0.alpha`.

## Installation
Add this line to your application's Gemfile:
Expand Down
4 changes: 2 additions & 2 deletions actionview-component.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ["lib"]

spec.required_ruby_version = ">= 2.5.0"
spec.required_ruby_version = ">= 2.3.0"

spec.add_development_dependency "bundler", ">= 1.14"
spec.add_development_dependency "rake", "~> 10.0"
spec.add_development_dependency "minitest", "~> 5.0"
spec.add_development_dependency "minitest", "= 5.1.0"
spec.add_development_dependency "haml", "~> 5"
spec.add_development_dependency "slim", "~> 4.0"
spec.add_development_dependency "rubocop", "~> 0.59"
Expand Down

0 comments on commit cee6871

Please sign in to comment.