Restore API documentation example for with_request_url's host param
#1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like this may have been inadvertently deleted in 231d4bb by regenerating the API docs. That happened because this example was manually added directly in `api.md` in 5decd07, rather than in the corresponding YARD comment. To fix this, we've added the example to the YARD comment and regenerated the API docs.
joelhawksley
deleted the
restore-api-docs-example-for-with_request_url-host-parameter
branch
|
Thanks Richard! hope you are well ❤️ |
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Dec 22, 2023
…ViewComponent#1794) It looks like this may have been inadvertently deleted in 231d4bb by regenerating the API docs. That happened because this example was manually added directly in `api.md` in 5decd07, rather than in the corresponding YARD comment. To fix this, we've added the example to the YARD comment and regenerated the API docs.
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Jan 3, 2024
…ViewComponent#1794) It looks like this may have been inadvertently deleted in 231d4bb by regenerating the API docs. That happened because this example was manually added directly in `api.md` in 5decd07, rather than in the corresponding YARD comment. To fix this, we've added the example to the YARD comment and regenerated the API docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Addresses #1771 (review)
It looks like this may have been inadvertently deleted by regenerating the API docs. That happened because this example was manually added directly in
api.mdin #1773, rather than in the corresponding YARD comment. To fix this, we've added the example to the YARD comment and regenerated the API docs.I did not include a changelog entry since this is just basically just reverting an inadvertent change from the most recent PR.