Fix API documentation and revert unnecessary change in preview.rb
#1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically, it's possible (though admittedly weird) to have an environment where `Rails.application` is present even if `Rails.application.routes.url_helpers` is not defined - and the change made to this line in 6979de9 would no longer handle that correctly.
Running `bundle exec rake docs:build` after 6979de9 produced a dirty git status, so we are committing the corresponding API documentation changes.
camertron
reviewed
Aug 25, 2023
camertron
approved these changes
Aug 25, 2023
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Dec 22, 2023
…iewComponent#1827) * Revert unnecessary change in lib/view_component/preview.rb Technically, it's possible (though admittedly weird) to have an environment where `Rails.application` is present even if `Rails.application.routes.url_helpers` is not defined - and the change made to this line in 6979de9 would no longer handle that correctly. * Regenerate API documentation to include latest changes Running `bundle exec rake docs:build` after 6979de9 produced a dirty git status, so we are committing the corresponding API documentation changes. * Add changelog entry
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Jan 3, 2024
…iewComponent#1827) * Revert unnecessary change in lib/view_component/preview.rb Technically, it's possible (though admittedly weird) to have an environment where `Rails.application` is present even if `Rails.application.routes.url_helpers` is not defined - and the change made to this line in 6979de9 would no longer handle that correctly. * Regenerate API documentation to include latest changes Running `bundle exec rake docs:build` after 6979de9 produced a dirty git status, so we are committing the corresponding API documentation changes. * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1774 (review)