Fix #with_request_url to ensure request.query_parameters is an instance of ActiveSupport::HashWithIndifferentAccess
#1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stance of ActiveSupport::HashWithIndifferentAccess
reeganviljoen
approved these changes
Aug 30, 2023
Spone
approved these changes
Aug 30, 2023
|
@Spone the only tests failing seem to be the flaky capture compatibility tests, so it seems safe to merge from my standpoint |
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Dec 22, 2023
…stance of ActiveSupport::HashWithIndifferentAccess (ViewComponent#1833)
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Jan 3, 2024
…stance of ActiveSupport::HashWithIndifferentAccess (ViewComponent#1833)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
When using the
#with_request_urltest helper,request.query_parametersreturnsHash, while Rails'request.query_parametersreturnsActiveSupport::HashWithIndifferentAccess.So I changed the
request.query_parametersin the#with_request_urltest helper to also returnActiveSupport::HashWithIndifferentAccess.