Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add favicon to fix flaky tests #2082

Merged
merged 1 commit into from
Aug 27, 2024
Merged

add favicon to fix flaky tests #2082

merged 1 commit into from
Aug 27, 2024

Commits on Aug 27, 2024

  1. add favicon to fix flaky tests 

    We've recently been seeing some flaky system test failures such as
https://github.com/ViewComponent/view_component/actions/runs/10582240672/job/29321458276?pr=2081
with the error `No route matches [GET] "/favicon.ico"`. It appears
as though the browser is trying to load a favicon and when it fails
to load before the test exits, causes the test to fail.
    @joelhawksley
    joelhawksley committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    0444a38 View commit details
    Browse the repository at this point in the history