Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor compiler for clarity #2091

Merged
merged 155 commits into from
Sep 11, 2024
Merged

Refactor compiler for clarity #2091

merged 155 commits into from
Sep 11, 2024

Commits on Aug 23, 2024

  1. add test case

    @joelhawksley
    joelhawksley committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    698e991 View commit details
    Browse the repository at this point in the history

  2. two tests remaining

    @joelhawksley
    joelhawksley committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    71f4adc View commit details
    Browse the repository at this point in the history

  3. first time all green

    @joelhawksley
    joelhawksley committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    d356ce8 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Merge branch 'main' into multi-format-component

    @joelhawksley
    joelhawksley authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    7c5cde5 View commit details
    Browse the repository at this point in the history

  2. Fix final line endings

    @github-actions
    github-actions[bot] committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    10d68ee View commit details
    Browse the repository at this point in the history

  3. add docs, changelog, test helpers

    @joelhawksley
    joelhawksley committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    229aaab View commit details
    Browse the repository at this point in the history

  4. Fix final line endings

    @github-actions
    github-actions[bot] committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    9560ca0 View commit details
    Browse the repository at this point in the history

  5. streamline compiler method generation

    @joelhawksley
    joelhawksley committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    9640e67 View commit details
    Browse the repository at this point in the history

  6. simplification

    @joelhawksley
    joelhawksley committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    4bacfd9 View commit details
    Browse the repository at this point in the history

  7. refactor to remove index usage

    @joelhawksley
    joelhawksley committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    eee9aec View commit details
    Browse the repository at this point in the history

  8. clearer control flow

    @joelhawksley
    joelhawksley committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    1331e41 View commit details
    Browse the repository at this point in the history

  9. lint

    @joelhawksley
    joelhawksley committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ac048cb View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into multi-format-component

    @joelhawksley
    joelhawksley authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    1170071 View commit details
    Browse the repository at this point in the history

  11. md lint

    @joelhawksley
    joelhawksley committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    7bbba51 View commit details
    Browse the repository at this point in the history

  12. remove remaining hardcoded formats

    @joelhawksley
    joelhawksley committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c44b5b3 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Update lib/view_component/base.rb 

    Co-authored-by: Blake Williams <blakewilliams@github.com>
    @joelhawksley @BlakeWilliams
    joelhawksley and BlakeWilliams authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    e46c231 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into multi-format-component

    @joelhawksley
    joelhawksley authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    955a52e View commit details
    Browse the repository at this point in the history

  3. remove unnecessary inspect

    @joelhawksley
    joelhawksley committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    6fb636a View commit details
    Browse the repository at this point in the history

  4. remove unused identifier

    @joelhawksley
    joelhawksley committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    87978c8 View commit details
    Browse the repository at this point in the history

  5. inline single-use method

    @joelhawksley
    joelhawksley committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    b55a94a View commit details
    Browse the repository at this point in the history

  6. add safe navigation

    @joelhawksley
    joelhawksley committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    61a6d61 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. consolidate template collision error messages to include format

    @joelhawksley
    joelhawksley committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    e77aecd View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. add backticks around variant name in error

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    9777f38 View commit details
    Browse the repository at this point in the history

  2. use one line syntax

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    067f09f View commit details
    Browse the repository at this point in the history

  3. no need to return false

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b0aaac8 View commit details
    Browse the repository at this point in the history

  4. inline single-use method

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    ce79fe4 View commit details
    Browse the repository at this point in the history

  5. remove offhand comment that would be better in the compiler, if at all

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b327ac2 View commit details
    Browse the repository at this point in the history

  6. inline barely used variable

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    e3aeb39 View commit details
    Browse the repository at this point in the history

  7. consolidate safe_class_name into default_method_name

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    54bd5cd View commit details
    Browse the repository at this point in the history

  8. use shorter component instead of component_class

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    bd16572 View commit details
    Browse the repository at this point in the history

  9. remove unnecessary conditional

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6cc7f99 View commit details
    Browse the repository at this point in the history

  10. remove unnecessary nesting

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    ab90237 View commit details
    Browse the repository at this point in the history

  11. inline single use method

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    e09adf9 View commit details
    Browse the repository at this point in the history

  12. remove intermediate compiler methods

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    ce15d3f View commit details
    Browse the repository at this point in the history

  13. InlineTemplate is now included by default

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    fcafca2 View commit details
    Browse the repository at this point in the history

  14. move comment to be in correct location

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6a351b4 View commit details
    Browse the repository at this point in the history

  15. start to make inline templates like other templates

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    c8f65c2 View commit details
    Browse the repository at this point in the history

  16. continue to consolidate inline template logic

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    08c8798 View commit details
    Browse the repository at this point in the history

  17. inline templates are just templates

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    c2e00b2 View commit details
    Browse the repository at this point in the history

  18. move lock to outside conditional

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    fa46d92 View commit details
    Browse the repository at this point in the history

  19. use same method_name definition

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    992c30d View commit details
    Browse the repository at this point in the history

  20. all templates have line numbers

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    85efee7 View commit details
    Browse the repository at this point in the history

  21. move towards single method definition path with source

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    18c7816 View commit details
    Browse the repository at this point in the history

  22. template handler is already present, no need to re-calculate

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    7cc3d2b View commit details
    Browse the repository at this point in the history

  23. just pass the template around instead of four params

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    c0c0787 View commit details
    Browse the repository at this point in the history

  24. use single class_eval to define template methods

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    dcfe939 View commit details
    Browse the repository at this point in the history

  25. remove unnecessary skipping of iterator

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    1e8715d View commit details
    Browse the repository at this point in the history

  26. make template hashes look the same

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    c4c06e9 View commit details
    Browse the repository at this point in the history

  27. move default slot registration to Slotable

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    fc49c1c View commit details
    Browse the repository at this point in the history

  28. define render_template_for in one place

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    ba825d8 View commit details
    Browse the repository at this point in the history

  29. remove duplicated method name construction

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    c3d6a37 View commit details
    Browse the repository at this point in the history

  30. sort nils last

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    4c8588a View commit details
    Browse the repository at this point in the history

  31. consolidate construction of safe_name

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f4aa2dd View commit details
    Browse the repository at this point in the history

  32. inline single-use method that at minimum should have been private

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    70e2f06 View commit details
    Browse the repository at this point in the history

  33. method name should not depend on templates state

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    daf544c View commit details
    Browse the repository at this point in the history

  34. set method name on template hash

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    4914d7a View commit details
    Browse the repository at this point in the history

  35. use method name from template hash

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    d46e307 View commit details
    Browse the repository at this point in the history

  36. shorten to one-line

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b504576 View commit details
    Browse the repository at this point in the history

  37. move conditional into existing file template conditional

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f52acfc View commit details
    Browse the repository at this point in the history

  38. simplify `templates

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    82c13ee View commit details
    Browse the repository at this point in the history

  39. remove unused formats method

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f7a93ab View commit details
    Browse the repository at this point in the history

  40. always set @templates at the same point vs. lazily

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2c46082 View commit details
    Browse the repository at this point in the history

  41. move compiled_template to Template

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    eb4bb63 View commit details
    Browse the repository at this point in the history

  42. clean up method name duplication

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    7dc5283 View commit details
    Browse the repository at this point in the history

  43. more clearly identify method name

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    56be8c2 View commit details
    Browse the repository at this point in the history

  44. move compile_to_component to Template

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    7229d1a View commit details
    Browse the repository at this point in the history

  45. construct template objects

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    aecea67 View commit details
    Browse the repository at this point in the history

  46. use template object in more places

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    bc5144e View commit details
    Browse the repository at this point in the history

  47. move html format check to template

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f560ef8 View commit details
    Browse the repository at this point in the history

  48. use format accessor on template

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    caeb5d7 View commit details
    Browse the repository at this point in the history

  49. move variant access to template

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5e0d3ad View commit details
    Browse the repository at this point in the history

  50. remove uses for method name from hash

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    cce39bd View commit details
    Browse the repository at this point in the history

  51. use template object in more locations

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    514a784 View commit details
    Browse the repository at this point in the history

  52. use template object in more places

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    9cd0aeb View commit details
    Browse the repository at this point in the history

  53. use existing template object

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b1db136 View commit details
    Browse the repository at this point in the history

  54. add comment for reload functionality

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6409c90 View commit details
    Browse the repository at this point in the history

  55. no more template hash!

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    1f2f144 View commit details
    Browse the repository at this point in the history

  56. do not define branches if it's not used

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    d6a152a View commit details
    Browse the repository at this point in the history

  57. use single code path for safe method definition for templates

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0894f78 View commit details
    Browse the repository at this point in the history

  58. consolidate render_template_for duplication

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b39874e View commit details
    Browse the repository at this point in the history

  59. consolidate to one-liner

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    186b9e2 View commit details
    Browse the repository at this point in the history

  60. consolidate to one-liner

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    7bb44b2 View commit details
    Browse the repository at this point in the history

  61. pass redefinition lock to template

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2056ca9 View commit details
    Browse the repository at this point in the history

  62. use template object for inline templates in render_template_for

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    7689673 View commit details
    Browse the repository at this point in the history

  63. remove unused method definition

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0b2cc43 View commit details
    Browse the repository at this point in the history

  64. simplify error check

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    871b62e View commit details
    Browse the repository at this point in the history

  65. use default method name in fewer cases

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    3cb912c View commit details
    Browse the repository at this point in the history

  66. remove unreachable code

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    9c3686e View commit details
    Browse the repository at this point in the history

  67. remove method name logic from compiler

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    3785905 View commit details
    Browse the repository at this point in the history

  68. simplify lookup of variants

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    4b6c787 View commit details
    Browse the repository at this point in the history

  69. inline variants accessor

    @joelhawksley
    joelhawksley committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0db8fdb View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. remove duplicative normalized_variant_name

    @joelhawksley
    joelhawksley committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    f122a71 View commit details
    Browse the repository at this point in the history

  2. add note about allowing inline_call / template collision

    @joelhawksley
    joelhawksley committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    d99e819 View commit details
    Browse the repository at this point in the history

  3. remove usage of inline_calls_defined_on_self

    @joelhawksley
    joelhawksley committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    011fb1c View commit details
    Browse the repository at this point in the history

  4. remove inline_calls_defined_on_self

    @joelhawksley
    joelhawksley committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    a0c7f9e View commit details
    Browse the repository at this point in the history

  5. inline_calls is only used once

    @joelhawksley
    joelhawksley committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    e01fc8b View commit details
    Browse the repository at this point in the history

  6. add todo around tracking template rendering

    @joelhawksley
    joelhawksley committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    bfdcff2 View commit details
    Browse the repository at this point in the history

  7. simplify conditional to use templates

    @joelhawksley
    joelhawksley committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    b39d9f8 View commit details
    Browse the repository at this point in the history

  8. simplify conditional

    @joelhawksley
    joelhawksley committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    24d8a33 View commit details
    Browse the repository at this point in the history

  9. make one-liner

    @joelhawksley
    joelhawksley committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    2456a3a View commit details
    Browse the repository at this point in the history

  10. gather_template_errors explicitly

    @joelhawksley
    joelhawksley committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    8531f11 View commit details
    Browse the repository at this point in the history

  11. use attr_reader to match templates

    @joelhawksley
    joelhawksley committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c63a414 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. move logic into template error construction

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    336077c View commit details
    Browse the repository at this point in the history

  2. couple template compilation with render method definition

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    dc25f1e View commit details
    Browse the repository at this point in the history

  3. define safe method as part of compilation

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1b2e883 View commit details
    Browse the repository at this point in the history

  4. extract Template#inline_call?

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    ab42dd1 View commit details
    Browse the repository at this point in the history

  5. inline inline_calls helper

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    a52524f View commit details
    Browse the repository at this point in the history

  6. use select instead of conditonal map+compact

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    a42f23b View commit details
    Browse the repository at this point in the history

  7. simplify logic and naming in duplicate detection

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3935d9b View commit details
    Browse the repository at this point in the history

  8. use more specific naming for variant pairs

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    941b38c View commit details
    Browse the repository at this point in the history

  9. inline

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    824735f View commit details
    Browse the repository at this point in the history

  10. passing around redef lock was messy

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9ce7234 View commit details
    Browse the repository at this point in the history

  11. initializer is longer than 120 chars

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    c93f998 View commit details
    Browse the repository at this point in the history

  12. let Ruby construct symbol string

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    e1162c3 View commit details
    Browse the repository at this point in the history

  13. simplify branch construction

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    8d24cb8 View commit details
    Browse the repository at this point in the history

  14. assign body as result of conditionals

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    c8ff887 View commit details
    Browse the repository at this point in the history

  15. use each_with_object to simplify

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    4854fa0 View commit details
    Browse the repository at this point in the history

  16. use syntactic sugar

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9b3c638 View commit details
    Browse the repository at this point in the history

  17. naming, method privacy

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1569d75 View commit details
    Browse the repository at this point in the history

  18. use default values

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5407eb0 View commit details
    Browse the repository at this point in the history

  19. inline inline_calls

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    87431a9 View commit details
    Browse the repository at this point in the history

  20. standardrb

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    e3bfb75 View commit details
    Browse the repository at this point in the history

  21. remove out-of-date comment

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    03415c3 View commit details
    Browse the repository at this point in the history

  22. shorten lines

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    f89456b View commit details
    Browse the repository at this point in the history

  23. use .first

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    e9151b7 View commit details
    Browse the repository at this point in the history

  24. remove attr_reader

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    e53d8a3 View commit details
    Browse the repository at this point in the history

  25. simplify compiler mode to be boolean

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1e71707 View commit details
    Browse the repository at this point in the history

  26. remove attr_reader

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    b2f23e8 View commit details
    Browse the repository at this point in the history

  27. extract constant for default format

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    f403700 View commit details
    Browse the repository at this point in the history

  28. Merge branch 'main' into refactor

    @joelhawksley
    joelhawksley committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3717343 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. split conditional into two lines for readibilty

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a59419e View commit details
    Browse the repository at this point in the history

  2. rename compiler mode to development mode

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    2b26f1b View commit details
    Browse the repository at this point in the history

  3. use any? with method extracted to template

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    aeb51b0 View commit details
    Browse the repository at this point in the history

  4. avoid use of _1

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    33af53c View commit details
    Browse the repository at this point in the history

  5. avoid use of _1

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    1399874 View commit details
    Browse the repository at this point in the history

  6. move Template to its own file

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    4819ff7 View commit details
    Browse the repository at this point in the history

  7. extract simplest case to conditional

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ccac374 View commit details
    Browse the repository at this point in the history

  8. Fix final line endings

    @github-actions
    github-actions[bot] committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    45d351a View commit details
    Browse the repository at this point in the history

  9. avoid block variable

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    97dc206 View commit details
    Browse the repository at this point in the history

  10. avoid more block variables

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    34d11c8 View commit details
    Browse the repository at this point in the history

  11. standardrb

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a3263bc View commit details
    Browse the repository at this point in the history

  12. add comment

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    e862541 View commit details
    Browse the repository at this point in the history

  13. memoize instance methods lookup

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a6aaed6 View commit details
    Browse the repository at this point in the history

  14. memoize instance method check

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    5130214 View commit details
    Browse the repository at this point in the history

  15. use single line for each argument

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    e10d42c View commit details
    Browse the repository at this point in the history

  16. add TODO for HTML output safety check

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    4882b3a View commit details
    Browse the repository at this point in the history

  17. extract and comment format and variant derivation from path

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f2b42a6 View commit details
    Browse the repository at this point in the history

  18. simpler extension extraction

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    34ca335 View commit details
    Browse the repository at this point in the history

  19. add explainer comments for format and variant extraction

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    570faeb View commit details
    Browse the repository at this point in the history

  20. use Hash with Set value to find conflicting variants

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a2d2f84 View commit details
    Browse the repository at this point in the history

  21. use single loop instead of two

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    201f6fa View commit details
    Browse the repository at this point in the history

  22. standardrb

    @joelhawksley
    joelhawksley committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    3d93a49 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. indicate constant is in internal

    @joelhawksley
    joelhawksley committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    839fd20 View commit details
    Browse the repository at this point in the history

  2. move redefinition lock back to compiler

    @joelhawksley
    joelhawksley committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    0c93a63 View commit details
    Browse the repository at this point in the history

  3. remove loop

    @joelhawksley
    joelhawksley committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    75e1c13 View commit details
    Browse the repository at this point in the history