Add basic internal testing for memory allocations #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joelhawksley many production set-ups use jemalloc(its even in the default dockerfile for rails) so it may be usefull to test against it aswell |
|
@reeganviljoen hmm. I'd worry about forcing folks to set up jemalloc locally in their dev environment to work against these tests. Do you think that'd be too much to ask? |
camertron
approved these changes
Sep 25, 2024
| ViewComponent::CompileCache.cache.delete(MyComponent) | ||
| MyComponent.ensure_compiled | ||
|
|
||
| assert_allocations("3.4.0" => 107, "3.3.5" => 116, "3.3.0" => 129, "3.2.5" => 115, "3.1.6" => 115, "3.0.7" => 125) do |
There was a problem hiding this comment.
Wow, pretty cool there's a ~15% decrease in allocations from Ruby 3.0 to 3.4 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR adds basic internal testing tooling for memory allocations, giving us a starting point for optimizing memory usage in the project.
What approach did you choose and why?
I copied the
assert_allocationshelper from Primer ViewComponents, but modified it to target specific Ruby versions to remove ambiguity.