Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add @private, undocumented .identifier method that was only me… #2109

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

joelhawksley
Copy link
Member

…ant for internal framework use but was used by some downstream consumers. This method will be removed in a coming minor release.

…ant for internal framework use but was used by some downstream consumers. This method will be removed in a coming minor release.
@joelhawksley
Copy link
Member Author

@jcoyne @rickychilcott @navidemad mind reviewing this change?

Copy link
Collaborator

@jcoyne jcoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. If we expected more consumers, other than newrelic (which I think is doubtful), I'd consider using ActiveSupport::Deprecation as it's a bit more flexible, but this is sufficient.

@joelhawksley joelhawksley merged commit 6fa2a91 into main Sep 30, 2024
18 of 19 checks passed
@joelhawksley joelhawksley deleted the fix-newrelic branch September 30, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants