Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove JS and CSS docs as they proved difficult to maintain #2194

Merged
merged 7 commits into from
Jan 16, 2025
Merged

remove JS and CSS docs as they proved difficult to maintain #2194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9b68a95
remove JS and CSS docs as they proved difficult to maintain
joelhawksley Jan 16, 2025
e463ddb
fix CI
joelhawksley Jan 16, 2025
ba353aa
use concurrent-ruby for 6.1 support
joelhawksley Jan 16, 2025
902ba77
use concurrent-ruby that works
joelhawksley Jan 16, 2025
6f33ac2
force 1.3.4
joelhawksley Jan 16, 2025
2b4d2b8
Update docs/CHANGELOG.md
joelhawksley Jan 16, 2025
30baf08
Update docs/CHANGELOG.md
joelhawksley Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ PATH
specs:
view_component (3.21.0)
activesupport (>= 5.2.0, < 8.1)
concurrent-ruby (~> 1.0)
concurrent-ruby (= 1.3.4)
method_source (~> 1.0)

GEM
Expand Down
4 changes: 4 additions & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ nav_order: 5

## main

* Remove JS and CSS docs as they proved difficult to maintain and lacked consensus.

*Joel Hawksley*

* Do not prefix release tags with `v`, per recommendation from @bkuhlmann.

*Joel Hawksley*
Expand Down
168 changes: 0 additions & 168 deletions docs/guide/javascript_and_css.md
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions test/sandbox/test/rendering_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ def test_render_inline_allocations
MyComponent.ensure_compiled

allocations = (Rails.version.to_f >= 8.0) ?
{"3.5.0" => 117, "3.4.1" => 117, "3.3.6" => 129} :
{"3.3.6" => 120, "3.3.0" => 120, "3.2.6" => 118, "3.1.6" => 118, "3.0.7" => 127}
{"3.5.0" => 117, "3.4.1" => 117, "3.3.7" => 129} :
{"3.3.7" => 120, "3.3.0" => 120, "3.2.6" => 118, "3.1.6" => 118, "3.0.7" => 127}

assert_allocations(**allocations) do
render_inline(MyComponent.new)
Expand Down
2 changes: 1 addition & 1 deletion view_component.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Gem::Specification.new do |spec|

spec.add_runtime_dependency "activesupport", [">= 5.2.0", "< 8.1"]
spec.add_runtime_dependency "method_source", "~> 1.0"
spec.add_runtime_dependency "concurrent-ruby", "~> 1.0"
spec.add_runtime_dependency "concurrent-ruby", "1.3.4" # lock version that supports Rails 6.1
spec.add_development_dependency "allocation_stats", "~> 0.1.5"
spec.add_development_dependency "appraisal", "~> 2.4"
spec.add_development_dependency "benchmark-ips", "~> 2.13.0"
Expand Down
Loading