Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to remove country code from numbers #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TheGP
Copy link
Contributor

@TheGP TheGP commented Feb 21, 2024

I put it in the settings to not crowd up getNumber function.
countries.json is excessive for a reason it will be used to use the code of the country to request the number instead of ID.

@TheGP
Copy link
Contributor Author

TheGP commented Feb 22, 2024

@Viiprogrammer what do you think about this? Basically its to call the method like sms.getNumber('tn', 'any', 'TH')
and I want to do the same with services and status codes, so code will be more readable

@Viiprogrammer
Copy link
Owner

@Viiprogrammer what do you think about this? Basically its to call the method like sms.getNumber('tn', 'any', 'TH') and I want to do the same with services and status codes, so code will be more readable

I will check tomorrow

@TheGP
Copy link
Contributor Author

TheGP commented Apr 2, 2024

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants