Refactor single file use and add tooling #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- all scripts in top-level directory: `chmod +x` - `convert_single.py`: shebang, sort imports (comment out unused settings import), move argparse to global scope, break out main function from magic method call - `.gitignore`: add `Brewfile.lock.json` exclusion - `.vscode`: configure python debugging w/boilerplate args, general python editor settings - `README.md`: replace generic brew requirements file w/semantic `Brewfile` and instructions; minimal shell scripting to get `tessdata` directory on mac; auto newline at EOF (unix requirement) - `Brewfile`: requirements file to programmatically install brew formulae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @VikParuchuri!
Thanks for making this! Added some general quality-of-life features/docs and light edits to the
convert_single.pyscript to get it in line with python conventions (e.g.,main()vs magic/dunder method call).Probably missed some stuff in subdirectories and won't be offended if you only use some of the below.
CHANGELOG
chmod +xconvert_single.py: shebang, sort imports (comment out unused settings import), move argparse to global scope, break out main function from magic method call.gitignore: addBrewfile.lock.jsonexclusion.vscode: configure python debugging w/boilerplate args, general python editor settingsREADME.md: replace generic brew requirements file w/semanticBrewfileand instructions; minimal shell scripting to gettessdatadirectory on mac; auto newline at EOF (unix requirement)Brewfile: requirements file to programmatically install brew formulae