Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the numpy dependency for koverage env #7

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Pin the numpy dependency for koverage env #7

merged 1 commit into from
Jun 26, 2024

Conversation

abhi18av
Copy link
Contributor

Hi @Vini2 ,

Congratulations on the great tool!

I am trying to integrate reneo into everest-nf and came across an issue during runtime

ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject

It seems that the problem might be the fact that pandas relies on a minimal version of numpy but not the maximum and since there are some breaking changes in numpy 2.0.0 the error propogates further up.

Reference: https://stackoverflow.com/a/78641304/6482586

CC @agudeloromero

@abhi18av
Copy link
Contributor Author

Actually, I've just faced another issue with koverage - perhaps @beardymcjohnface might be able to provide a more stable fix for the koverage release.

The error I have now come across is related to jupyter

    raise DPClientError(f"{type(b.data).__name__} not supported for {self.__class__.__name__}")
datapane.client.exceptions.DPClientError: DataFrame not supported for XMLBuilder
Please run with `dp.enable_logging()`, restart your Jupyter kernel/Python instance, and/or visit https://www.github.com/datapane/datapane

@Vini2
Copy link
Owner

Vini2 commented Jun 25, 2024

Hi @abhi18av,

Thanks for your interest in Reneo and thanks for raising this issue and putting a PR. I'll pin the numpy version in reneo.yaml as well and publish a new release.

@beardymcjohnface can you please take a look at this issue?

Thanks!

@beardymcjohnface
Copy link
Collaborator

@Vini2 if you want a quick fix and you don't need the koverage HTML report, then I would add --no-report to the koverage step in rule koverage_genomes. Unfortunately, generating the report uses a few libraries that can be flakey. I just ran it fine on a fresh install on our VM but the error has popped up before.

@Vini2
Copy link
Owner

Vini2 commented Jun 26, 2024

Thanks @beardymcjohnface! I'll add the --no-report flag for now to publish a new release.

@Vini2 Vini2 merged commit 1e284a8 into Vini2:develop Jun 26, 2024
11 checks passed
Vini2 added a commit that referenced this pull request Jun 26, 2024
@abhi18av abhi18av deleted the patch-1 branch June 26, 2024 09:06
@abhi18av
Copy link
Contributor Author

Thank you both for the quick progress here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants