[bug fix] Allow commiting of files large than 100mb if handled by LFS #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimonGisler
changed the title
Vinzent03
requested changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin refuses to add files bigger than 100mb if the remote is github, even if an file is handled by LFS.
I added some logic that checks if a file is (or will be) handled by LFS, before blocking the commit.
Detailed Problem Description
Commit Where Check for Too Big Files Was Added
I have not yet implemented IsomorphicGit, but I am happy to do that if I get feedback on whether my change is being considered.
The changes were only tested on my Windows 11 machine (not on Linux or macOS).
This is my first ever PR to an open source project, so any feedback is welcome. I would be very happy if this actually were merged. :D