Open
Conversation
Contributor
Author
|
FYI I've manually fixed the latest curation xrefs added over the last month. |
… until we have something more specific Ref VirtualFlyBrain/Management#315
dosumis
reviewed
Feb 2, 2023
Member
dosumis
left a comment
There was a problem hiding this comment.
This one might go round forever. The problem is down to whether this has a label in input ontologies (=> de facto standard label => database_cross_reference as edge name) or not (=> hasDbXref as edge name). I think we've gone back and forth on a solution. Do avoid churn, it might be best to ensure that this label is injected via VFB_ext.owl and that we have a test in place to stop any variants on this creeping in.
Contributor
|
label is already in vfbext: |
Member
OK. Should all be good then. Not sure why the test is failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still some issues from curation loading into KB. Hopefully, this closes all the issues.