Share logic between sbt and mill for setting scalacOptions #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
WojciechMazur
commented
Jan 3, 2024
WojciechMazur
commented
- Share algorith of filtering and adding scalacOptions
- Move mill scalacOptions setting to runtime, resolve from sys properties
- Improve mill version detection, don't use coursier, instead fallback to millw. Always build with detected version if no ./mill file script found
- Always set -source:3.x-migration flag
- Always set/remove some of common scalacOptions (deprecations, fatal warning, linting)
…t for detection and for running the build. Always use version of build detected in mill/prepare-project
…x-migration and common flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.