Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure consecutive -Wconf:* flags are not ignored #3245

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Ensure consecutive -Wconf:* flags are not ignored #3245

merged 2 commits into from
Oct 25, 2024

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Oct 24, 2024 •
edited
Loading

a fix for the issue noted in scala/scala3#21818 (comment)

@Gedochao Gedochao marked this pull request as ready for review October 24, 2024 09:34
@Gedochao Gedochao requested a review from tgodzik October 24, 2024 09:35
@Gedochao
Copy link
Contributor Author

cc @SethTisue @prolativ

tgodzik
tgodzik approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Gedochao Gedochao changed the title Ensure consecutive -Wconf:* flags are not ignored Ensure consecutive -Wconf:* flags are not ignored Oct 24, 2024
@Gedochao Gedochao merged commit 7751341 into VirtusLab:main Oct 25, 2024
53 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchyb jchyb jchyb left review comments

@prolativ prolativ prolativ approved these changes

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gedochao @tgodzik @prolativ @jchyb